Skip to content
This repository has been archived by the owner on May 24, 2024. It is now read-only.

[carbon-graphs] Add multiple value region support for line graphs #359

Merged
merged 8 commits into from
May 8, 2024

Conversation

sycombs
Copy link
Collaborator

@sycombs sycombs commented May 6, 2024

Summary

This PR adds support for multiple value regions on a line or multiline graph so that different regions may be displayed on a per-value basis.

Testing

This change was tested using:

  • WDIO
  • Jest (WIP - currently the Jest tests are failing after migrating from Karma to Jest)
  • Visual testing (please attach a screenshot or recording)
  • Other (please describe below)
  • No tests are needed

Also performed manual testing with various datasets.

Reviews

In addition to engineering reviews, this PR needs:

  • UX review
  • Accessibility review
  • Functional review

Additional Details

This PR resolves:

UXPLATFORM-9529


Thank you for contributing to Terra.
@cerner/terra

@github-actions github-actions bot temporarily deployed to preview-pr-359 May 7, 2024 13:45 Destroyed
@sycombs sycombs self-assigned this May 7, 2024
@sycombs sycombs marked this pull request as ready for review May 7, 2024 13:52
@sycombs sycombs requested a review from a team May 7, 2024 18:23
@sycombs sycombs merged commit 844749f into main May 8, 2024
10 checks passed
@sycombs sycombs deleted the multiple-value-regions branch May 8, 2024 15:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants